[#6236] fix(core): fix possible resource leak in BaseCatalog #6253
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinmclean @tengqm ,could you please review this PR when you have time? I’d really appreciate your feedback. |
fix possible resource leak in BaseCatalog.
…ate the plugin (apache#6246) Authorization should use classloader to create the plugin Fix: apache#6245 No. I tested it manually.
fix possible resource leak in BaseCatalog.
jerqi
reviewed
Jan 15, 2025
| BaseAuthorization<?> authorization = | ||
| BaseAuthorization.createAuthorization(classLoader, authorizationProvider); | ||
|
|
||
| try (BaseAuthorization<?> authorization = |
There was a problem hiding this comment.
Should the authorization be closed after creating plugin? Do we need close method? cc @xunliu
There was a problem hiding this comment.
I think this change is ok.
Another question is:
Should the authorization be closed after creating plugin? Do we need close method? cc @xunliu
We already closed the authorization plugin in the core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java#L229
@Override
public void close() throws IOException {
if (ops != null) {
ops.close();
ops = null;
}
if (authorizationPlugin != null) {
authorizationPlugin.close();
authorizationPlugin = null;
}
if (catalogCredentialManager != null) {
catalogCredentialManager.close();
catalogCredentialManager = null;
}
}
There was a problem hiding this comment.
In my opinion, Authorization class is similar to a factory class. It's weird that the factory class has close method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
try-with-resourceto fix possible resource leak in BaseCatalog.Why are the changes needed?
Fix: #6236
Does this PR introduce any user-facing change?
No.
How was this patch tested?
local test.